Skip to content

agent: Add support for keep-alive SSH messages #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtojek opened this issue May 17, 2023 · 4 comments · Fixed by #8062
Closed

agent: Add support for keep-alive SSH messages #7581

mtojek opened this issue May 17, 2023 · 4 comments · Fixed by #8062
Assignees
@mtojek
Milestone
🦛 Sprint 1

Comments

@mtojek
Copy link
Member

mtojek commented May 17, 2023

Related: gliderlabs/ssh#12
Related: #7512

Introducing the default max timeout in #7532 impaired the SSHJ client used by VS Code extension that expects an idle connection. The goal of this issue is to implement the Keep-Alive ping-pong mechanism on the Coder SSH server side so that users with Max Timeout can still use the VS Code extension.
@mtojek
Copy link
Member Author

mtojek commented May 17, 2023

@kylecarbs @code-asher Any thoughts about this?

@mtojek mtojek mentioned this issue May 17, 2023
Closed
@mtojek mtojek self-assigned this May 18, 2023
@code-asher
Copy link
Member

code-asher commented May 19, 2023 via email

@mtojek
Copy link
Member Author

mtojek commented May 22, 2023

We could also work around it on the extension side for now by setting ServerAliveInterval right?

There are 2 use cases:

  1. coder ssh: in this case crypto/ssh (Go SDK) needs to implement something like ServerAliveInterval. I'm not sure if it does it in the way we expect. Also, our SSH server implementation should reply to the message, right? At least it should ACK and ignore the "ping" message.
    2 ssh coder (stdio mode): we need the SSH server support for "ping" messages (as above).

@code-asher
Copy link
Member

code-asher commented May 22, 2023 via email

This was referenced Jun 7, 2023
Closed
Merged
@mtojek mtojek added this to the ❓Sprint 1 milestone Jun 12, 2023
@mtojek mtojek mentioned this issue Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
🦛 Sprint 1
Development

Successfully merging a pull request may close this issue.

feat: replace ssh maxTimeout with keep-alive mechanism coder/coder
2 participants
@mtojek @code-asher