Skip to content

Encrypt OIDC access token in database #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronlehmann opened this issue May 22, 2023 · 3 comments
Closed

Encrypt OIDC access token in database #7640

aaronlehmann opened this issue May 22, 2023 · 3 comments
Assignees
Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this.

Comments

@aaronlehmann
Copy link
Contributor

Users' OIDC access tokens are currently stored in plaintext in the Postgres DB. Given the sensitivity of these tokens, we would prefer if they were stored encrypted.

For our deployment, it would work fine to manage the encryption key outside of Coder in an existing secrets manager and pass it in via a file path or directly inside an environment variable.

@kylecarbs kylecarbs self-assigned this May 24, 2023
@bpmct bpmct added the must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. label Aug 17, 2023
@ammario ammario assigned mtojek and unassigned kylecarbs Aug 18, 2023
@mtojek mtojek assigned johnstcn and kylecarbs and unassigned mtojek and kylecarbs Aug 21, 2023
@johnstcn
Copy link
Member

Original PR: #7959

@johnstcn
Copy link
Member

Broke this up into two PRs for ease of review:

@johnstcn johnstcn closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this.
Projects
None yet
Development

No branches or pull requests

6 participants