Skip to content

Add --wait option to coder ssh #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
mafredri opened this issue Jun 1, 2023 · 0 comments · Fixed by #7894
Closed
2 tasks

Add --wait option to coder ssh #7768

mafredri opened this issue Jun 1, 2023 · 0 comments · Fixed by #7894
Assignees
@mafredri
Labels
cli Area: CLI
Milestone
🧹 Sprint 0

Comments

@mafredri
Copy link
Member

mafredri commented Jun 1, 2023 •
edited
Loading

Currently coder ssh supports --no-wait, however, there is no way for a user to wait if they want to. To fix this, we will add --wait (and accompanying env) to coder ssh.

  • Add --wait flag that always waits for startup script
  • Error if both --wait and --no-wait are provided
@mafredri mafredri added feature cli Area: CLI labels Jun 1, 2023
@mafredri mafredri mentioned this issue Jun 1, 2023
Closed
@mafredri mafredri self-assigned this Jun 1, 2023
@mafredri mafredri added this to the 🧹 Sprint 0 milestone Jun 1, 2023
@mafredri mafredri mentioned this issue Jun 7, 2023
Merged
mafredri added a commit that referenced this issue Jun 7, 2023
@mafredri
feat(cli): Add wait and no-wait support to config-ssh
6494ad9 
Refs #7768
@mafredri mafredri mentioned this issue Jun 7, 2023
Merged
mafredri added a commit that referenced this issue Jun 7, 2023
@mafredri
feat(cli): Add wait and no-wait support to ssh
ffbdf29 
Fixes #7768
Refs #7893
mafredri added a commit that referenced this issue Jun 7, 2023
@mafredri
feat(cli): Add wait and no-wait support to config-ssh
a47b44c 
Refs #7768
mafredri added a commit that referenced this issue Jun 7, 2023
@mafredri
feat(cli): Add wait and no-wait support to config-ssh
f4ec444 
Refs #7768
mafredri added a commit that referenced this issue Jun 7, 2023
@mafredri
feat(cli): Add wait and no-wait support to ssh
2afc35c 
Fixes #7768
Refs #7893
mafredri added a commit that referenced this issue Jun 7, 2023
@mafredri
feat(cli): Add wait and no-wait support to ssh
08da521 
Fixes #7768
Refs #7893
mafredri added a commit that referenced this issue Jun 7, 2023
@mafredri
feat(cli): Add wait and no-wait support to ssh
2f223fe 
Fixes #7768
Refs #7893
mafredri added a commit that referenced this issue Jun 8, 2023
@mafredri
feat(cli/ssh): implement wait options and deprecate no-wait (#7894)
94aa9be 
Fixes #7768
Refs #7893
mafredri added a commit that referenced this issue Jun 8, 2023
@mafredri
feat(cli/configssh): add support for wait yes/no/auto (#7893)
a1c3295 
Refs #7768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
cli Area: CLI
Projects
None yet
Milestone
🧹 Sprint 0
Development

Successfully merging a pull request may close this issue.

feat(cli/ssh): implement wait options and deprecate no-wait coder/coder
1 participant
@mafredri