Skip to content

Web terminal notification for "Startup script failed" does not account for terminal size #7914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mafredri opened this issue Jun 8, 2023 · 7 comments · Fixed by #12444
Closed

Web terminal notification for "Startup script failed" does not account for terminal size #7914

mafredri opened this issue Jun 8, 2023 · 7 comments · Fixed by #12444
Assignees
@BrunoQuaresma
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard

Comments

@mafredri
Copy link
Member

mafredri commented Jun 8, 2023

image

It seems the notification banner is throwing off the terminal size and showing content outside the window (depending on window size).

The terminal status bar at the bottom also seems to disappear with this notification, but not with the "startup script is still running" one.
@mafredri mafredri added site Area: frontend dashboard bug labels Jun 8, 2023
@mafredri mafredri mentioned this issue Jun 8, 2023
Closed
3 tasks
@bpmct bpmct added the s2 Broken use cases or features (with a workaround). Only humans may set this. label Aug 7, 2023
@BrunoQuaresma
Copy link
Collaborator

@mafredri do you have a workspace where I can test this out?

@mafredri
Copy link
Member Author

mafredri commented Aug 9, 2023

@BrunoQuaresma mafredri/webterm-size-issue.

  1. Open Terminal (standard size)
  2. Type ls -lha
  3. Dismiss notification
  4. Try scrolling

@bpmct bpmct added s3 Bugs that confuse, annoy, or are purely cosmetic and removed s2 Broken use cases or features (with a workaround). Only humans may set this. labels Aug 25, 2023
@matifali
Copy link
Member

This would probably be fixed by #9320, @mafredri can you please test in https://codercom.slack.com/archives/C05DNE982E8/p1692944206280609

@mafredri
Copy link
Member Author

@matifali tested but it doesn't, I think it's more a problem in how the HTML is represented.

@github-actions github-actions bot added the stale This issue is like stale bread. label Feb 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
@mafredri
Copy link
Member Author

mafredri commented Mar 1, 2024 •
edited
Loading

This is still an issue, reopening.

@mafredri mafredri reopened this Mar 1, 2024
@github-actions github-actions bot removed the stale This issue is like stale bread. label Mar 3, 2024
@BrunoQuaresma
Copy link
Collaborator

Wondering if we should just display snack bar notifications on this page so Xterm does not have to do extra calc to get it right. Thoughts?

@BrunoQuaresma BrunoQuaresma self-assigned this Mar 4, 2024
@matifali
Copy link
Member

matifali commented Mar 5, 2024

If this makes the UX better let's try it out. We can test this and revert if we see any issues.

@BrunoQuaresma BrunoQuaresma mentioned this issue Mar 6, 2024
Merged
BrunoQuaresma added a commit that referenced this issue Mar 8, 2024
@BrunoQuaresma
fix(site): fix terminal size when displaying alerts (#12444)
060033e 
Before - The terminal size does not fit the available space so the bottom is hidden.

https://github.com/coder/coder/assets/3165839/d08470b9-9fc6-476c-a551-8a3e13fc25bf

After - The terminal adjusts when there are alert changes.

https://github.com/coder/coder/assets/3165839/8cc32bfb-056f-47cb-97f2-3bb18c5fe906

Unfortunately, I don't think there is a sane way to automate tests for this but open to suggestions.

Close #7914
mtojek pushed a commit that referenced this issue Mar 8, 2024
@BrunoQuaresma @mtojek
fix(site): fix terminal size when displaying alerts (#12444)
69790d7 
Before - The terminal size does not fit the available space so the bottom is hidden.

https://github.com/coder/coder/assets/3165839/d08470b9-9fc6-476c-a551-8a3e13fc25bf

After - The terminal adjusts when there are alert changes.

https://github.com/coder/coder/assets/3165839/8cc32bfb-056f-47cb-97f2-3bb18c5fe906

Unfortunately, I don't think there is a sane way to automate tests for this but open to suggestions.

Close #7914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(site): fix terminal size when displaying alerts coder/coder
4 participants
@mafredri @BrunoQuaresma @matifali @bpmct