-
Notifications
You must be signed in to change notification settings - Fork 881
Gaps between lines and performance issues in web terminal #7953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@BrunoQuaresma — please take a look. |
Sorry, but I'm not seeing the issue. Can you please guide me to where is the visual glitch? |
Hi @BrunoQuaresma , for further information I'm using Egde on Windows and Google Chrome on Linux. On both browsers this happens. Here is another example: |
What command are you running to see these outputs? |
I've started midnight commander. But it is the same in bashtop (first screenshot). I tried to downgrade to v0.23.7 but database migration fails so I can not switch easily back. I'm not a FE developer. Let me know if I can provide some useful information. |
I think this is good enough, thank you! |
Looks like it is a bug on xterm since the line height is "self calculated". cc.: @code-asher Maybe it was introduced in the latest Dependabot upgrade. Is it something you can take a look at? |
This seems not be be a new issue. xtermjs/xterm.js#475 |
Thanks for letting us know @MrPeacockNLB |
Interesting, seems to be a bug in the DOM renderer. My guess is the default renderer in xterm switched from canvas to DOM so we should explicitly set it back to canvas. I thought we were using DOM explicitly before but that was just for a test so I was wrong, we were actually just using the default which was canvas (I just tested to be sure). |
Does it look better when using canvas? |
Yup, no spaces with canvas, just solid lines. |
I've also noticed some performance Issues. Espacially when typing text in WebTerminal. Maybe they are related to DOM as well? Not sure... Nice to hear that switching back to canves fixes line drawing! |
I bet you are right, from my recollection the switch to canvas was largely motivated by performance. |
Description
After updating to latest release v0.24.0 terminal apps like lazygit, midnight commander, bashtop show spaces between rows. See screenshot below as an example.
Resizing with zoom or zoom 100% has no effects.
Maybe it is related to #7765
The text was updated successfully, but these errors were encountered: