Skip to content

Gaps between lines and performance issues in web terminal #7953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrPeacockNLB opened this issue Jun 10, 2023 · 15 comments · Fixed by #8138
Closed

Gaps between lines and performance issues in web terminal #7953

MrPeacockNLB opened this issue Jun 10, 2023 · 15 comments · Fixed by #8138
Assignees
Labels
s1 Bugs that break core workflows. Only humans may set this.
Milestone

Comments

@MrPeacockNLB
Copy link
Contributor

MrPeacockNLB commented Jun 10, 2023

Description

After updating to latest release v0.24.0 terminal apps like lazygit, midnight commander, bashtop show spaces between rows. See screenshot below as an example.

image

Resizing with zoom or zoom 100% has no effects.

Maybe it is related to #7765

@cdr-bot cdr-bot bot added the bug label Jun 10, 2023
@ammario ammario added the s1 Bugs that break core workflows. Only humans may set this. label Jun 10, 2023
@ammario
Copy link
Member

ammario commented Jun 10, 2023

@BrunoQuaresma — please take a look.

@BrunoQuaresma
Copy link
Collaborator

Sorry, but I'm not seeing the issue. Can you please guide me to where is the visual glitch?

@MrPeacockNLB
Copy link
Contributor Author

Hi @BrunoQuaresma ,

for further information I'm using Egde on Windows and Google Chrome on Linux. On both browsers this happens.

Here is another example:

image

@BrunoQuaresma
Copy link
Collaborator

What command are you running to see these outputs?

@MrPeacockNLB
Copy link
Contributor Author

MrPeacockNLB commented Jun 12, 2023

I've started midnight commander. But it is the same in bashtop (first screenshot). I tried to downgrade to v0.23.7 but database migration fails so I can not switch easily back.

I'm not a FE developer. Let me know if I can provide some useful information.

@MrPeacockNLB
Copy link
Contributor Author

Here a screenshot from lazygit.

image

@BrunoQuaresma
Copy link
Collaborator

I think this is good enough, thank you!

@BrunoQuaresma
Copy link
Collaborator

Looks like it is a bug on xterm since the line height is "self calculated". cc.: @code-asher Maybe it was introduced in the latest Dependabot upgrade. Is it something you can take a look at?

@MrPeacockNLB
Copy link
Contributor Author

This seems not be be a new issue. xtermjs/xterm.js#475

@BrunoQuaresma
Copy link
Collaborator

Thanks for letting us know @MrPeacockNLB

@code-asher
Copy link
Member

code-asher commented Jun 12, 2023

Interesting, seems to be a bug in the DOM renderer.

My guess is the default renderer in xterm switched from canvas to DOM so we should explicitly set it back to canvas. I thought we were using DOM explicitly before but that was just for a test so I was wrong, we were actually just using the default which was canvas (I just tested to be sure).

@BrunoQuaresma
Copy link
Collaborator

Does it look better when using canvas?

@sreya sreya added this to the 🦛 Sprint 1 milestone Jun 13, 2023
@code-asher
Copy link
Member

Yup, no spaces with canvas, just solid lines.

@MrPeacockNLB
Copy link
Contributor Author

I've also noticed some performance Issues. Espacially when typing text in WebTerminal. Maybe they are related to DOM as well? Not sure...

Nice to hear that switching back to canves fixes line drawing!

@code-asher
Copy link
Member

I bet you are right, from my recollection the switch to canvas was largely motivated by performance.

@code-asher code-asher changed the title Visual glichtes in WebTerminal Gap between lines in web terminal Jun 27, 2023
@code-asher code-asher changed the title Gap between lines in web terminal Gap between lines and performance issues in web terminal Jun 27, 2023
@code-asher code-asher changed the title Gap between lines and performance issues in web terminal Gaps between lines and performance issues in web terminal Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s1 Bugs that break core workflows. Only humans may set this.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants