Skip to content

Setting appearance without a color fails silently #8187

@code-asher

Description

@code-asher

Reproduction:

  1. Start a brand new deployment.
  2. Open appearance settings.
  3. Toggle enabled and add a message. Do not touch the color.
  4. Submit.

Behavior:

Nothing happens. Checking the network request reveals:

{
    "message": "parse color: expected 7 characters:\n    github.com/coder/coder/enterprise/coderd.validateHexColor\n        /home/coder/coder/enterprise/coderd/appearance.go:114"
}

After manually setting the color submitting always works. It is just that first request where we are not sending any color.

Solution:

  • Surface errors
  • Set default color if none yet

Metadata

Metadata

Assignees

Labels

s2Broken use cases or features (with a workaround). Only humans may set this.siteArea: frontend dashboard

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions