Skip to content

Workspaces can be created with invalid values, then cannot be deleted #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #777
jsjoeio opened this issue Apr 1, 2022 · 6 comments · Fixed by #1732
Closed
Tracked by #777

Workspaces can be created with invalid values, then cannot be deleted #831

jsjoeio opened this issue Apr 1, 2022 · 6 comments · Fixed by #1732
Assignees
@deansheather
Labels
api Area: HTTP API
Milestone
Community MVP

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 1, 2022

Description

If you create a new workspace with invalid values, there are a couple unexpected things:

  • you can't reuse that name (i.e. coder doesn't automatically delete the invalid workspace)
  • you can't delete the workspace
  • you can't edit the workspace to fix the invalid value

Steps to Reproduce

  1. `../coder workspaces create test-workspace``
  2. Select a project
  3. Enter invalid disk size (i.e. 3)
  4. See Error

Logs

Can't reuse workspace name

➜  aws-linux ../coder workspaces create joes-workspace
Select a project:                                         

> Creating with the  aws-linux  project...
Error: A workspace already exists named "joes-workspace"!

Can't delete workspace

➜  aws-linux ../coder workspaces delete joes-workspace
✔ Queued [51ms]
✔ Setting up [1ms]
⧗  Destroying workspace 
  Terraform 1.1.7
  Error: Invalid value for variable
  Disk size must be between 8 and 256.                       
                                                           
This was checked by the validation rule at main.tf:40,3-13.
✘ Destroying workspace [6114ms]
Error: recv workspace provision: read file "/var/folders/c7/ns6lqzvx3z10mq647y5g9lqc0000gn/T/provisionerd3690011094/terraform.tfstate": open /var/folders/c7/ns6lqzvx3z10mq647y5g9lqc0000gn/T/provisionerd3690011094/terraform.tfstate: no such file or directory

Can't edit workspace

➜  aws-linux ../coder workspaces edit joes-workspace
Usage:
  coder workspaces [command]

Aliases:
  workspaces, ws

Commands:
  create      Create a workspace from a project
  delete      
  list        
  show        
  ssh         
  start       
  stop        
  update      

Flags:
  -h, --help   help for workspaces

Global Flags:
      --global-config coder   Path to the global coder config directory (default "/Users/jp/Library/Application Support/coderv2")

Use "coder workspaces [command] --help" for more information about a command.
➜  aws-linux ../coder workspaces update joes-workspace
Workspace isn't outdated!
@tjcran tjcran added this to the Community MVP milestone May 11, 2022
@misskniss misskniss mentioned this issue May 12, 2022
Closed
17 tasks
@misskniss
Copy link

Hey team! Please add your planning poker estimate with ZenHub @kylecarbs @coadler

@kconley-sq
Copy link
Contributor

I've just run into this myself. :( Is there any workaround to delete the invalid workspace (even if it involves hitting some API endpoint manually)?

@kylecarbs
Copy link
Member

You can grab the state with coder state pull <name> and terraform destroy yourself with parameters. We'll be fixing this soon!

@kconley-sq
Copy link
Contributor

How does coder state pull work? I'm running coder state pull <NAME_OF_WORKSPACE> and the command succeeds without any terminal output or any files created in my working directory.

I'm also not sure there are any terraform resources I need to destroy (because none were created originally for this invalid workspace) - is there a different path I should take to just remove coderd's knowledge of the invalid workspace?

@kylecarbs
Copy link
Member

Ahh, you're in a locked state then, unfortunately. This is something I'll have a patch out for in a few days though, so for now I suppose just leave that workspace hanging 😥.

@kconley-sq kconley-sq mentioned this issue May 17, 2022
Closed
@deansheather deansheather changed the title coder workspaces with invalid values Cannot delete workspace if created with invalid values May 19, 2022
This was referenced May 19, 2022
Closed
Merged
@deansheather
Copy link
Member

This issue is mitigated by #1594 (which allows you to delete workspaces in this broken state), but I will be making further effort to catch validation errors earlier on.

@deansheather deansheather self-assigned this May 24, 2022
@misskniss misskniss mentioned this issue May 24, 2022
Closed
@deansheather deansheather changed the title Cannot delete workspace if created with invalid values Workspaces can be created with invalid values, then cannot be deleted May 24, 2022
@deansheather deansheather mentioned this issue May 25, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deansheather deansheather

Labels
api Area: HTTP API
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

feat: run a terraform plan before creating workspaces with the given template parameters coder/coder
6 participants
@misskniss @jsjoeio @tjcran @kylecarbs @deansheather @kconley-sq