-
Notifications
You must be signed in to change notification settings - Fork 881
workspace schedule: If I update my workspace, the autostop resets to updated_at + 12 hours #8546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Clicking the "update" button performs the following actions:
The underlying issue here appears to be the perception of "restart" being different than "stop" followed by "start", which is not the case. |
@matifali can you clarify the impact of this issue? Is it just confusing, or is there a bigger knock-on effect that I'm missing here? |
@johnstcn It is just different from the perceived expected behavior. A workspace should strictly follow the autostart autostop schedule, and a version update in the middle of the day should not push the auto-stop deadline further. |
@matifali Should restarting the workspace in the middle of the day also not push the auto-stop deadline further? What about stopping the workspace, waiting 1 minute, and starting the workspace again? My main question is:- should a start within the autostop window of a previous start honour the previous autostop window? |
Yes
Yes Also @bpmct can add further comments. Maybe I misunderstood the expected behavior. My understanding is that autostart/autostop are for cost control and should be followed strictly unless the workspace is active at autostop time.(In that case we automatically bump the shutdown time) See: #2995 |
@matifali OK, so just to make sure we're both on the same page: Say a user starts a workspace at If a user then starts their workspace again at
|
@johnstcn Yes, exactly. This is my understanding of the expected behavior. |
I gave it a 2nd thought and there can be 2 situations.
In short. For autostop, we can keep our current behavior when there is no auto-start set but should strictly follow autostart time when it is set. |
|
The autostop TTL is the amount of time of inactivity before the workspace is autostopped. It's not related to the autostart time at all. #8115 reworks max_ttl on templates and doesn't impact the inactivity TTL. |
@deansheather, I could not understand how this is going to be addressed. |
I have my workspace to start daily at 8 AM and then autostop after 12 hours (8 PM).
I updated my workspace at 2:49 PM with a new template version, and now my autostop time shows 2:49 AM.
Expected
Workspace should follow the original autostop schedule 12 hours after autostart (18 PM).
Actual
Workspace says

The text was updated successfully, but these errors were encountered: