Skip to content

All Terminals Disconnect On Single Close #8772

Closed
@ElioDiNino

Description

@ElioDiNino

Version: v0.27.1+65583ec

Problems

  1. When you have multiple terminals open for a given workspace (and/or coder_apps that run a command) and you close one of them, they all show the disconnected screen (photos below)
  2. The disconnect screen says "Press any key to retry" but the only valid keys (at least on macOS) seem to be control, option, command, space bar, and shift.

Example

Various terminals open
Screenshot 2023-07-27 at 9 18 01 AM

After closing one terminal
Screenshot 2023-07-27 at 9 21 59 AM

Activity

kylecarbs

kylecarbs commented on Jul 27, 2023

@kylecarbs
Member

Oof, this is a weird bug. We'll definitely fix it.

spettinichi

spettinichi commented on Aug 1, 2023

@spettinichi

Came here to mention the "any key" confuses people, we had to start telling people to hit space, so thank you for identifying more keys which work! We are also mostly on Mac, so unsure about other OSes but I will see if I can gather more information.
This also explains some weirdness we've seen with terminals timing out seemingly too quickly.

spettinichi

spettinichi commented on Aug 1, 2023

@spettinichi

Spoke with someone else and same issues on Windows. The working keys seem to be space, shift, alt, ctrl, and the windows key.

matifali

matifali commented on Aug 2, 2023

@matifali
Member

@spettinichi you are right I can reproduce it on Windows. Part 2 of the OP is a duplicate of #8547

added
s2Broken use cases or features (with a workaround). Only humans may set this.
on Aug 2, 2023
spettinichi

spettinichi commented on Aug 2, 2023

@spettinichi

Ahh thanks for linking that! I didn't realize there was already a separate ticket for Windows!

kconley-sq

kconley-sq commented on Aug 2, 2023

@kconley-sq
Contributor

I encountered into this issue too on v0.27.3 and noticed that in addition to affecting other web terminals, if you close a web terminal while having some other workspace application open then it also seems to interfere with that application.

For example, the window for Android Studio via JetBrains Projector shows the following for a few seconds after you close a web terminal window:

image

After a few seconds, the workspace application stops showing that connection message and goes back to normal.

added
s1Bugs that break core workflows. Only humans may set this.
and removed
s2Broken use cases or features (with a workaround). Only humans may set this.
on Aug 3, 2023
bpmct

bpmct commented on Aug 4, 2023

@bpmct
Member

We're able to reproduce this consistently on some of our clients and are investigating!

self-assigned this
on Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

s1Bugs that break core workflows. Only humans may set this.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    All Terminals Disconnect On Single Close · Issue #8772 · coder/coder