Skip to content

test flake: TestDERPHeaders #9107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Aug 15, 2023 · 0 comments · Fixed by #9262
Closed

test flake: TestDERPHeaders #9107

spikecurtis opened this issue Aug 15, 2023 · 0 comments · Fixed by #9262
Assignees
@deansheather @code-asher

Comments

@spikecurtis
Copy link
Contributor

coder ping can apparently sometimes succeed without calling DERP from the client side.

sometimes we get

ptytest.go:131: 2023-08-15 09:59:53.190: cmd: "pong from upbeat-aryabhata8-p2T p2p via  172.20.0.6:60589  in 0s"

instead of

ptytest.go:131: 2023-08-15 10:13:31.289: cmd: "pong from kind-hopper4-9WU proxied via  DERP(Coder Embedded Relay)  in 1ms"

and /derp is never called with the headers.

TestDERPHeaders.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deansheather deansheather

@code-asher code-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix flake in TestDERPHeaders coder/coder
3 participants
@spikecurtis @deansheather @code-asher