Skip to content

add health check for proxy #9558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #8971
ericpaulsen opened this issue Sep 6, 2023 · 4 comments · Fixed by #10846
Closed
Tracked by #8971

add health check for proxy #9558

ericpaulsen opened this issue Sep 6, 2023 · 4 comments · Fixed by #10846
Assignees
@johnstcn
Milestone
healthcheck GA

Comments

@ericpaulsen
Copy link
Member

ericpaulsen commented Sep 6, 2023 •
edited by mtojek
Loading

if proxies are out of date with the server version, unexpected behavior can occur. the health check endpoint /api/v2/debug/health should display configured proxies, their versions and health
@bpmct
Copy link
Member

bpmct commented Sep 6, 2023

This is important because the provisioner code may include "breaking changes" such as parsing values differently. If the provisioner is out of date, the user could see very strange behavior.

@bpmct bpmct mentioned this issue Sep 6, 2023
Closed
16 tasks
@ericpaulsen ericpaulsen changed the title add health check for out-of-date provisioner or proxy during ugprade add health check for out-of-date provisioner or proxy during upgrade Sep 6, 2023
@matifali matifali added this to the healthcheck GA milestone Sep 19, 2023
@MrPeacockNLB
Copy link
Contributor

Thumbs up, as we yesterday trapped (shame on me) into this again

@mtojek
Copy link
Member

mtojek commented Nov 14, 2023 •
edited
Loading

Re proxies:

I presume that the goal of this issue is to expose the same data as for /api/v2/workspaceproxies.

@mtojek mtojek changed the title add health check for out-of-date provisioner or proxy during upgrade add health check for proxy Nov 14, 2023
@mtojek mtojek mentioned this issue Nov 14, 2023
Closed
8 tasks
@johnstcn johnstcn self-assigned this Nov 17, 2023
@johnstcn
Copy link
Member

johnstcn commented Nov 17, 2023 •
edited
Loading

We'll probably need to add a version column to the workspace_proxies table for this.
Proxies already send their version along when they hit the /register endpoint.

This was referenced Nov 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
healthcheck GA
Development

Successfully merging a pull request may close this issue.

feat(coderd/healthcheck): add health check for proxy coder/coder
6 participants
@johnstcn @ericpaulsen @matifali @mtojek @bpmct @MrPeacockNLB