Skip to content

site: Remove just-debounce-it from all React renders #9706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parkreiner opened this issue Sep 15, 2023 · 1 comment · Fixed by #9707
Closed

site: Remove just-debounce-it from all React renders #9706

Parkreiner opened this issue Sep 15, 2023 · 1 comment · Fixed by #9707
Assignees
@Parkreiner
Labels
good first issue Easily solved issues suitable for starters and community contributors

Comments

@Parkreiner
Copy link
Member

Parkreiner commented Sep 15, 2023 •
edited
Loading

This is a continuation of issue #9547 and PR #9703.

As part of the fix, just-debounce-it was replaced with a custom useDebouncedFunction hook. This hook provides the same debounce functionality, but is safe to use inside of React, and is insulated against its re-renders.

However, there are still a few components that are using the previous library. Those will need to be replaced, and assuming debounce-it is no longer being used, it should be removed from the project's dependencies.
@cdr-bot cdr-bot bot added the chore label Sep 15, 2023
@Parkreiner Parkreiner added bug good first issue Easily solved issues suitable for starters and community contributors labels Sep 15, 2023
@Parkreiner
Copy link
Member Author

Going to take this one really quick. The remaining debounce calls seem easy to update, with very little rippling out to other components

@Parkreiner Parkreiner self-assigned this Sep 15, 2023
@Parkreiner Parkreiner changed the title site: Remove debounce-it from all React renders site: Remove just-debounce-it from all React renders Sep 15, 2023
@Parkreiner Parkreiner mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Parkreiner Parkreiner

Labels
good first issue Easily solved issues suitable for starters and community contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove just-debounce-it coder/coder
1 participant
@Parkreiner