Skip to content

flake: Tests for TemplateSchedulePage sometimes time out #9793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parkreiner opened this issue Sep 20, 2023 · 5 comments
Closed

flake: Tests for TemplateSchedulePage sometimes time out #9793

Parkreiner opened this issue Sep 20, 2023 · 5 comments
Assignees
@Parkreiner
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@Parkreiner
Copy link
Member

Already working on this – just filing it as an issue for documentation purposes.
Link to test logs

Log excerpt:

FAIL test src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.test.tsx (78.533 s)
  ● TemplateSchedulePage › succeeds

    thrown: "Exceeded timeout of 20000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      110 |   });
      111 |
    > 112 |   it("succeeds", async () => {
          |   ^
      113 |     await renderTemplateSchedulePage();
      114 |     jest.spyOn(API, "updateTemplateMeta").mockResolvedValueOnce({
      115 |       ...MockTemplate,

      at it (src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.test.tsx:112:3)
      at Object.describe (src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.test.tsx:102:1)
@Parkreiner Parkreiner self-assigned this Sep 20, 2023
@cdr-bot cdr-bot bot added the chore label Sep 20, 2023
@Parkreiner Parkreiner added the bug label Sep 20, 2023
@matifali matifali added the s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks label Sep 20, 2023
@Parkreiner
Copy link
Member Author

Parkreiner commented Sep 20, 2023 •
edited
Loading

Tested this from a couple of different angles, and I wasn't able to track down the source of the non-deterministic tests.

I think there's a decent chance that there's something in the form components that's causing the button to still be disabled when it's clicked, but I don't know what would make that behavior only sometimes error out

@Parkreiner Parkreiner mentioned this issue Sep 20, 2023
Merged
@matifali matifali removed the chore label Oct 10, 2023
@Parkreiner
Copy link
Member Author

Going to close this one out. I haven't seen this test flake on us in the past two months.

@mtojek mtojek reopened this Dec 4, 2023
@mtojek
Copy link
Member

mtojek commented Dec 4, 2023

It is back!

Link: https://github.com/coder/coder/actions/runs/7087701151/job/19288568901?pr=11021

@Parkreiner
Copy link
Member Author

Okay, I'll start digging even deeper

@stirby
Copy link
Collaborator

stirby commented Apr 4, 2024

Closing as stale @Parkreiner.

@stirby stirby closed this as completed Apr 4, 2024
@stirby stirby closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Parkreiner Parkreiner

Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matifali @mtojek @Parkreiner @stirby