Skip to content

test flake: Test_parseInsightsInterval_week: Query param "end_time" must have the clock set to 00:00:00 #9873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Sep 26, 2023 · 1 comment · Fixed by #9874
Closed

test flake: Test_parseInsightsInterval_week: Query param "end_time" must have the clock set to 00:00:00 #9873

johnstcn opened this issue Sep 26, 2023 · 1 comment · Fixed by #9874
Assignees
@johnstcn
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@johnstcn
Copy link
Member

Seen here:

=== Failed
=== FAIL: coderd Test_parseInsightsInterval_week/Two_weeks (0.00s)
    insights_internal_test.go:239: Status:  400
    insights_internal_test.go:240: Body:  {
        	"message": "Query parameter has invalid value.",
        	"validations": [
        		{
        			"field": "end_time",
        			"detail": "Query param \"end_time\" must have the clock set to 00:00:00"
        		}
        	]
        }
        
    insights_internal_test.go:242: 
        	Error Trace:	/home/runner/actions-runner/_work/coder/coder/coderd/insights_internal_test.go:242
        	Error:      	Should be true
        	Test:       	Test_parseInsightsInterval_week/Two_weeks
        	Messages:   	start_time and end_time must be valid

=== FAIL: coderd Test_parseInsightsInterval_week (0.00s)
@johnstcn johnstcn added flake s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks labels Sep 26, 2023
@johnstcn
Copy link
Member Author

johnstcn commented Sep 26, 2023 •
edited
Loading

https://go.dev/play/p/sfYpSkgcV3E - seems to be time-related

@johnstcn johnstcn self-assigned this Sep 26, 2023
@johnstcn johnstcn mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(coderd/insights_internal_test.go): remove troublesome test case coder/coder
1 participant
@johnstcn