Skip to content

Can't set service banner background color – background color sometimes changes from hex to HSL format #9888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtojek opened this issue Sep 27, 2023 · 4 comments · Fixed by #9893
Closed

Can't set service banner background color – background color sometimes changes from hex to HSL format #9888

mtojek opened this issue Sep 27, 2023 · 4 comments · Fixed by #9893
Assignees
@Parkreiner

Comments

@mtojek
Copy link
Member

mtojek commented Sep 27, 2023

It is not possible to set the color now as submitted value has incorrect format:

Screenshot 2023-09-27 at 15 17 23

It would be nice to cover it with tests.
@cdr-bot cdr-bot bot added the bug label Sep 27, 2023
@Parkreiner Parkreiner self-assigned this Sep 27, 2023
@Parkreiner Parkreiner changed the title Can't set service banner background color Can't set service banner background color – background color sometimes changes from hex to HSL format Sep 27, 2023
@mtojek
Copy link
Member Author

mtojek commented Sep 27, 2023

@Parkreiner I'm wondering if this is some kind of regression we introduced by blindly accepting the Dependabot lib update.

@Parkreiner
Copy link
Member

@mtojek Yeah, I'm still trying to figure out the root of the cause, but at the very least, I'm putting in some more safety nets to intercept non-hex strings. If the non-hex can safely be converted, I'm turning it into a hex string, and letting that through, but rejecting the input if I can't

@mtojek
Copy link
Member Author

mtojek commented Sep 27, 2023

Isn't it a problem with the color value selected initially?

It looks to me like colors.blue[7].

@Parkreiner
Copy link
Member

Ah, that would be it. Good catch!

@Parkreiner Parkreiner mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add checks for preventing HSL colors from entering React state coder/coder
2 participants
@mtojek @Parkreiner