Skip to content

chore: refactor Pill styles #10004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2023
Merged

chore: refactor Pill styles #10004

merged 3 commits into from
Oct 3, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 3, 2023

  • Use emotion!
  • Allow overriding theme settings to make certain variants look nicer/more consistent with the rest

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing Storybook I noticed the icon sizes are "broken"

@aslilac aslilac requested a review from BrunoQuaresma October 3, 2023 16:32
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aslilac aslilac merged commit 4b97ac2 into main Oct 3, 2023
@aslilac aslilac deleted the cuter-pill branch October 3, 2023 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
@aslilac aslilac linked an issue Oct 3, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace makeStyles
2 participants