From 251583939bf855e6c9a0f897c4e6da43f23188d4 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Tue, 3 Oct 2023 14:17:29 +0000 Subject: [PATCH] fix: do not require `client_secret` for external auth providers Device-based auth does not need a client secret. --- coderd/externalauth/externalauth.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/coderd/externalauth/externalauth.go b/coderd/externalauth/externalauth.go index 4db6ec695c3dd..34bd7e9253ee7 100644 --- a/coderd/externalauth/externalauth.go +++ b/coderd/externalauth/externalauth.go @@ -383,9 +383,6 @@ func ConvertConfig(entries []codersdk.ExternalAuthConfig, accessURL *url.URL) ([ if entry.ClientID == "" { return nil, xerrors.Errorf("%q external auth provider: client_id must be provided", entry.ID) } - if entry.ClientSecret == "" { - return nil, xerrors.Errorf("%q external auth provider: client_secret must be provided", entry.ID) - } _, exists := ids[entry.ID] if exists {