fix(site): change utils/delay import path
#10065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason this fails when imported into `vscode-coder`.
```
ERROR in /home/coder/vscode-coder/node_modules/coder/site/src/api/api.ts
./node_modules/coder/site/src/api/api.ts 6:22-35
[tsl] ERROR in /home/coder/vscode-coder/node_modules/coder/site/src/api/api.ts(6,23)
TS2307: Cannot find module 'utils/delay' or its corresponding type declarations.
```
After changing the import to add `../xxx` the error went away. I don't
really understand why.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
utils/delay import pathutils/delay import path
kylecarbs
approved these changes
Oct 4, 2023
|
I think it'd be kinda nice to have a separate TS api package that we can pull out of site/ so that we don't have to deal with weird build things like this in vscode-coder, or wherever else we need TS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason this fails when imported into
vscode-coder.After changing the import to add
../xxxthe error went away. I don'treally understand why.