fix: use UTF-8 encoding with screen #10190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make characters like ❯ and ⇣ work, for example.
mafredri
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Thanks for fixing!
Too bad the test didn't work out. But tbh it might be best to not rely on vt10x too much, I see the project doesn't even have the issue tracker active.
Could we perhaps verify if this works via a regular pty? We don't really need to verify that the output is structured correctly, just see if we can find the correct UTF-8 characters we're looking for.
Oh duh! Pushing a test now. I verified it fails without |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make characters like ❯ and ⇣ work, for example.
Honestly I am not 100% sure of the consequences but defaulting to UTF-8 seems reasonable?
I experimented with adding a test but without success (for either backend); maybe the vt10x emulator we use in the tests does not support UTF-8. I did confirm it works manually though.
Fixes #9343