From 7aa4a01a7c62a5f31de95f272d6f5060f509b4f0 Mon Sep 17 00:00:00 2001 From: Parkreiner Date: Thu, 12 Oct 2023 00:16:00 +0000 Subject: [PATCH 1/2] fix: only used 'unnamed' as a last resort for templates --- site/src/pages/WorkspacesPage/WorkspacesButton.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/pages/WorkspacesPage/WorkspacesButton.tsx b/site/src/pages/WorkspacesPage/WorkspacesButton.tsx index 550d344e82293..02c20c39c2d5c 100644 --- a/site/src/pages/WorkspacesPage/WorkspacesButton.tsx +++ b/site/src/pages/WorkspacesPage/WorkspacesButton.tsx @@ -84,7 +84,7 @@ function WorkspaceResultsRow({ template }: { template: Template }) { sx={{ marginY: 0, paddingBottom: 0.5, lineHeight: 1 }} noWrap > - {template.display_name || "[Unnamed]"} + {template.display_name || template.name || "[Unnamed]"} Date: Thu, 12 Oct 2023 00:18:58 +0000 Subject: [PATCH 2/2] fix: update filter logic to read from name field --- site/src/pages/WorkspacesPage/WorkspacesButton.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/site/src/pages/WorkspacesPage/WorkspacesButton.tsx b/site/src/pages/WorkspacesPage/WorkspacesButton.tsx index 02c20c39c2d5c..c6c238e5dff9a 100644 --- a/site/src/pages/WorkspacesPage/WorkspacesButton.tsx +++ b/site/src/pages/WorkspacesPage/WorkspacesButton.tsx @@ -37,7 +37,11 @@ function sortTemplatesByUsersDesc( const termMatcher = new RegExp(searchTerm.replaceAll(/[^\w]/g, "."), "i"); return templates - .filter((template) => termMatcher.test(template.display_name)) + .filter( + (template) => + termMatcher.test(template.display_name) || + termMatcher.test(template.name), + ) .sort((t1, t2) => t2.active_user_count - t1.active_user_count) .slice(0, 10); }