Skip to content

feat: add all safe experiments to the deployment page #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 17, 2023
Merged

feat: add all safe experiments to the deployment page #10276

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ebe2d93
added new option table type for experiments
Kira-Pilot Oct 15, 2023
00ea98e
added tests
Kira-Pilot Oct 15, 2023
7819735
fixed go tests
Kira-Pilot Oct 15, 2023
c120794
Merge branch 'main' into experiment-visual-2/kira-pilot
Kira-Pilot Oct 15, 2023
e6215c0
Merge remote-tracking branch 'origin/main' into experiment-visual-2/k…
Kira-Pilot Oct 16, 2023
776356e
added go test for new param
Kira-Pilot Oct 16, 2023
9a2605a
removing query change
Kira-Pilot Oct 16, 2023
f13b815
clearing ExperimentsAll
Kira-Pilot Oct 16, 2023
aa65ff0
dont mutate ExperimentsAll
Kira-Pilot Oct 16, 2023
2422316
added new route for safe experiments
Kira-Pilot Oct 16, 2023
308dbb1
added new route for safe experiments
Kira-Pilot Oct 16, 2023
ad7a3d0
added test for new route
Kira-Pilot Oct 17, 2023
82a513b
PR feedback
Kira-Pilot Oct 17, 2023
42e8bd6
altered design
Kira-Pilot Oct 17, 2023
9ed5f35
alias children
Kira-Pilot Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR feedback
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed Oct 17, 2023
commit 82a513ba339beea242d829b51e71688b8efee739
46 changes: 24 additions & 22 deletions site/src/components/DeploySettingsLayout/Option.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,28 +85,30 @@ export const OptionValue: FC<OptionValueProps> = (props) => {
if (typeof children === "object" && !Array.isArray(children)) {
return (
<ul css={listStyles}>
{Object.entries(children).map(([option, isEnabled]) => (
<li key={option} css={optionStyles}>
<Box
sx={{
display: "inline-flex",
alignItems: "center",
}}
>
{option}
{isEnabled && (
<CheckCircleOutlined
sx={{
width: 16,
height: 16,
color: (theme) => theme.palette.success.light,
margin: (theme) => theme.spacing(0, 1),
}}
/>
)}
</Box>
</li>
))}
{Object.entries(children)
.sort((a, b) => a[0].localeCompare(b[0]))
.map(([option, isEnabled]) => (
<li key={option} css={optionStyles}>
<Box
sx={{
display: "inline-flex",
alignItems: "center",
}}
>
{option}
{isEnabled && (
<CheckCircleOutlined
sx={{
width: 16,
height: 16,
color: (theme) => theme.palette.success.light,
margin: (theme) => theme.spacing(0, 1),
}}
/>
)}
</Box>
</li>
))}
</ul>
);
}
Expand Down
9 changes: 5 additions & 4 deletions site/src/components/DeploySettingsLayout/optionValue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,12 @@ export function optionValue(
{} as Record<string, boolean>,
);

if (!experimentMap) {
break;
}

for (const v of option.value) {
if (
experimentMap &&
Object.prototype.hasOwnProperty.call(experimentMap, v)
) {
if (Object.hasOwn(experimentMap, v)) {
experimentMap[v] = true;
}
}
Expand Down