Skip to content

chore(site): remove update check service #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2023
Merged

chore(site): remove update check service #10355

merged 4 commits into from
Oct 20, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Related to #9942

@BrunoQuaresma BrunoQuaresma requested a review from a team October 19, 2023 18:46
@BrunoQuaresma BrunoQuaresma self-assigned this Oct 19, 2023
@BrunoQuaresma BrunoQuaresma requested review from Parkreiner and removed request for a team October 19, 2023 18:46
Parkreiner
Parkreiner reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to approve just yet, because I'm concerned the thrown error might be too aggressive in some situations, but I don't know how you see things

@BrunoQuaresma BrunoQuaresma requested review from Parkreiner and a team October 20, 2023 12:32
Parkreiner
Parkreiner approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BrunoQuaresma BrunoQuaresma merged commit 3d9bfdd into main Oct 20, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/remove-update-check-service branch October 20, 2023 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @Parkreiner