Skip to content

chore: pin devcontainer.json to pre-nix image #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2023
Merged

chore: pin devcontainer.json to pre-nix image #10417

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e22fbd3
chore: fix devcontainer.json
matifali Oct 30, 2023
a9fe721
use pre-nix tag
matifali Oct 30, 2023
a940a08
Update devcontainer.json
matifali Oct 30, 2023
31abd90
remove privileged
matifali Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: fix devcontainer.json 
fixes #10416
  • Loading branch information
@matifali
matifali authored Oct 30, 2023
commit e22fbd319cfb047ef2a9c7fabecda219ac1e4416
7 changes: 4 additions & 3 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@

"features": {
// See all possible options here https://github.com/devcontainers/features/tree/main/src/docker-in-docker
"ghcr.io/devcontainers/features/docker-in-docker:2": {}
"ghcr.io/devcontainers/features/docker-in-docker:2": {
"moby": "false"
}
},
// SYS_PTRACE to enable go debugging
// without --priviliged the Github Codespace build fails (not required otherwise)
"runArgs": ["--cap-add=SYS_PTRACE", "--privileged"]
"runArgs": ["--cap-add=SYS_PTRACE"]
}