Skip to content

refactor(site): make minor design tweaks and fix issues on more options menus #10493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 3, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Fix menus not closing when clicking and navigating to a lazy loaded page
  • Minor design tweaks
  • Make all "More options" menus consistent

Before:

Screenshot 2023-11-02 at 10 21 02 Screenshot 2023-11-02 at 10 18 03 Screenshot 2023-11-02 at 10 07 40

Now:

Screenshot 2023-11-02 at 10 21 07 Screenshot 2023-11-02 at 10 18 08 Screenshot 2023-11-02 at 10 07 48

@BrunoQuaresma BrunoQuaresma requested a review from a team November 2, 2023 13:32
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 2, 2023
@BrunoQuaresma BrunoQuaresma requested review from Parkreiner and removed request for a team November 2, 2023 13:32
@BrunoQuaresma BrunoQuaresma changed the title refactor(site): fixes and minor design tweaks on more options menus refactor(site): make minor design tweaks and fix issues on more options menus Nov 2, 2023
@Parkreiner
Copy link
Member

Parkreiner commented Nov 2, 2023

Little mentally spent from reviewing the XState PR from this morning (I can't imagine how you felt making it), but I'll definitely have this reviewed by this evening

@BrunoQuaresma BrunoQuaresma merged commit 716b86b into main Nov 3, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-more-menu branch November 3, 2023 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants