Skip to content

fix: remove accidental scrollbar from deployment banner #10616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Nov 9, 2023

No issue to link. At some point in the last month, we accidentally introduced a mini scrollbar on the deployment banner. This PR removes that.

Screenshot 2023-11-09 at 3 36 35 PM

@Parkreiner Parkreiner added site Area: frontend dashboard s3 Bugs that confuse, annoy, or are purely cosmetic bug labels Nov 9, 2023
@Parkreiner Parkreiner self-assigned this Nov 9, 2023
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner
Copy link
Member Author

@BrunoQuaresma Sorry to ping you for the review, but I decided to make this a hotfix, just because the issue and fix seemed so clear-cut

@Parkreiner Parkreiner changed the title fix: remove scrollbar from deployment banner fix: remove accidental scrollbar from deployment banner Nov 9, 2023
@Parkreiner Parkreiner removed the request for review from BrunoQuaresma November 9, 2023 20:45
@Parkreiner Parkreiner merged commit 8290fee into main Nov 9, 2023
@Parkreiner Parkreiner deleted the mes/bugs/baby-scrollbar branch November 9, 2023 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant