Skip to content

chore: use /usr/bin/env bash #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

chore: use /usr/bin/env bash #1070

merged 1 commit into from
Apr 19, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 19, 2022

This PR fixes an issue with running the ./develop.sh script where /bin/bash is modified differently on a user's local machine. This change also makes ./develop.sh and ./yarn_install.sh more consistent.

Subtasks

  • tested locally

@jsjoeio jsjoeio self-assigned this Apr 19, 2022
@jsjoeio jsjoeio requested review from code-asher and presleyp April 19, 2022 15:37
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1070 (a46ee80) into main (c8246e3) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   66.79%   66.61%   -0.19%     
==========================================
  Files         262      259       -3     
  Lines       15653    15469     -184     
  Branches      152      152              
==========================================
- Hits        10456    10304     -152     
+ Misses       4136     4118      -18     
+ Partials     1061     1047      -14     
Flag Coverage Δ
unittest-go-macos-latest 53.40% <ø> (-0.20%) ⬇️
unittest-go-postgres- 66.04% <ø> (+0.07%) ⬆️
unittest-go-ubuntu-latest 55.92% <ø> (+0.04%) ⬆️
unittest-go-windows-2022 ?
unittest-js 67.96% <ø> (ø)
Impacted Files Coverage Δ
cli/configssh.go 61.41% <0.00%> (-7.09%) ⬇️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
peer/conn.go 75.38% <0.00%> (-3.81%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
provisionerd/provisionerd.go 81.02% <0.00%> (-0.89%) ⬇️
provisioner/echo/serve.go 59.20% <0.00%> (ø)
pty/pty_windows.go
pty/start_windows.go
agent/usershell/usershell_windows.go
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8246e3...a46ee80. Read the comment docs.

@jsjoeio jsjoeio merged commit 73b8a5a into main Apr 19, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-script branch April 19, 2022 15:45
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants