From 04d4f2ec9497076a19dc95285dc46687baa75dbd Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Fri, 24 Nov 2023 12:17:26 +0100 Subject: [PATCH] fix: healthcheck warnings should be empty array --- coderd/healthcheck/derphealth/derp.go | 2 ++ coderd/healthcheck/derphealth/derp_test.go | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/coderd/healthcheck/derphealth/derp.go b/coderd/healthcheck/derphealth/derp.go index d6081a7f2eec8..4f6271cfc8169 100644 --- a/coderd/healthcheck/derphealth/derp.go +++ b/coderd/healthcheck/derphealth/derp.go @@ -166,6 +166,7 @@ func (r *RegionReport) Run(ctx context.Context) { r.Healthy = true r.Severity = health.SeverityOK r.NodeReports = []*NodeReport{} + r.Warnings = []string{} wg := &sync.WaitGroup{} var unhealthyNodes int // atomic.Int64 is not mandatory as we depend on RegionReport mutex. @@ -262,6 +263,7 @@ func (r *NodeReport) Run(ctx context.Context) { r.Severity = health.SeverityOK r.ClientLogs = [][]string{} r.ClientErrs = [][]string{} + r.Warnings = []string{} wg := &sync.WaitGroup{} diff --git a/coderd/healthcheck/derphealth/derp_test.go b/coderd/healthcheck/derphealth/derp_test.go index 50172581dd2f4..fd389f4e62f53 100644 --- a/coderd/healthcheck/derphealth/derp_test.go +++ b/coderd/healthcheck/derphealth/derp_test.go @@ -68,6 +68,8 @@ func TestDERP(t *testing.T) { for _, node := range region.NodeReports { assert.True(t, node.Healthy) assert.True(t, node.CanExchangeMessages) + assert.Empty(t, node.Warnings) + assert.NotNil(t, node.Warnings) assert.NotEmpty(t, node.RoundTripPing) assert.Len(t, node.ClientLogs, 2) assert.Len(t, node.ClientLogs[0], 3) @@ -128,6 +130,8 @@ func TestDERP(t *testing.T) { for _, region := range report.Regions { assert.True(t, region.Healthy) assert.True(t, region.NodeReports[0].Healthy) + assert.Empty(t, region.NodeReports[0].Warnings) + assert.NotNil(t, region.NodeReports[0].Warnings) assert.Equal(t, health.SeverityOK, region.NodeReports[0].Severity) assert.False(t, region.NodeReports[1].Healthy) assert.Equal(t, health.SeverityError, region.NodeReports[1].Severity)