feat: allow templates to specify max_ttl or autostop_requirement #10920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
approved these changes
Dec 11, 2023
| MaxTTL time.Duration `json:"max_ttl"` | ||
| // UseMaxTTL dictates whether the max_ttl should be used instead of | ||
| // autostop_requirement for this template. This is governed by the template | ||
| // and licensing. | ||
| // TODO(@dean): remove this when we remove max_tll |
There was a problem hiding this comment.
Do we still intend to remove max_ttl? Or remove this comment?
There was a problem hiding this comment.
Yes, it's deprecated
| } | ||
| enterpriseTemplateStore.UseAutostopRequirement.Store(true) | ||
|
|
||
| quietHoursStore, err := schedule.NewEnterpriseUserQuietHoursScheduleStore(api.DefaultQuietHoursSchedule) | ||
| if err != nil { | ||
| api.Logger.Error(ctx, "unable to set up enterprise user quiet hours schedule store, template autostop requirements will not be applied to workspace builds", slog.Error(err)) |
There was a problem hiding this comment.
now that we have the Health page, it would be cool if we could elevate this kind of stuff to there.
| @@ -121,6 +122,7 @@ export const FormSection: FC< | |||
| > | |||
| {title} | |||
| {alpha && <AlphaBadge />} | |||
| {deprecated && <DeprecatedBadge />} | |||
There was a problem hiding this comment.
Can you drop a screencap with what this looks like?
aslilac
reviewed
Dec 11, 2023
site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateScheduleForm.tsx
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_ttlandautostop_requirementat the same time in deploymentsCRON_TZ=UTC 0 0 * * *for quiet hours schedule (so it's always enabled if entitled, can be overridden with flag still)template_autostop_requirement, merged intoadvanced_template_schedulingTODO:
Create template form
chrome_8fiabxzSQz.mp4
Edit template form
chrome_UcH8t1ESW6.mp4
Closes #9284