fix: clear workspace name validation on field dirty #10927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,6 +127,7 @@ const CreateWorkspacePage: FC = () => { | |||
| defaultOwner={me} | |||
| defaultBuildParameters={defaultBuildParameters} | |||
| error={createWorkspaceMutation.error} | |||
| resetMutation={createWorkspaceMutation.reset} | |||
There was a problem hiding this comment.
For me, resetMutation does not say too much about its intention. Maybe resetError could be a better name?
| @@ -157,7 +159,8 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({ | |||
| <TextField | |||
| {...getFieldHelpers("name")} | |||
| disabled={creatingWorkspace} | |||
| onChange={onChangeTrimmed(form)} | |||
| // resetMutation facilitates the clearing of validation errors | |||
| onChange={onChangeTrimmed(form, resetMutation)} | |||
There was a problem hiding this comment.
We should not have to reset the mutation to clear the form error. But I think it is probably out of scope since it looks to be an issue with how we use the getFormHelpers gets the errors.
BrunoQuaresma
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10637