feat: support v2 Tailnet API in AGPL coordinator #11010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
803e89e to
3f7d00c
Compare
coadler
approved these changes
Dec 6, 2023
Comment on lines
+717
to
+727
| <h2 id=tunnels><a href=#tunnels>#</a> tunnels: total {{ len .Tunnels }}</h2> | ||
| <table> | ||
| <tr style="margin-top:4px"> | ||
| <th>SrcID</th> | ||
| <th>DstID</th> | ||
| </tr> | ||
| {{- range .Tunnels }} | ||
| <tr style="margin-top:4px"> | ||
| <td>{{ .Src }}</td> | ||
| <td>{{ .Dst }}</td> | ||
| </tr> |
There was a problem hiding this comment.
I think this would be easier to read if the tunnels for each peer were underneath each row instead of being in a big list at the end.
There was a problem hiding this comment.
You're right, of course, but as often as we look at this thing it's hard for me to get excited about saving a couple CTRL+F on the output.
3f7d00c to
c16c2b8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10529