fix: stop updating agent stats from deleted workspaces #11026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Dec 7, 2023
Emyrk
reviewed
Dec 7, 2023
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Emyrk
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not solve #10820, but I found it while I was in the area. I figure this should probably be the behavior, but let me know if I'm wrong.
This was from a hunch that orphaned workspace agents were still reporting stats and causing stats to be incorrect on the dashboard. This does not seem to be the case for my original bug, but I think this check is still valid.