Skip to content

fix: make install references incorrect folders #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2022
Merged

fix: make install references incorrect folders #1105

merged 1 commit into from
Apr 22, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 22, 2022

No description provided.

@coadler coadler self-assigned this Apr 22, 2022
@coadler coadler marked this pull request as ready for review April 22, 2022 20:27
kylecarbs
kylecarbs approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the double GOOS intentional?

@coadler
Copy link
Contributor Author

coadler commented Apr 22, 2022

Yeah, the folders look like this now:

$ ls dist
artifacts.json                coder-linux_linux_arm64      coder-windows_windows_amd64_v1
coder-darwin_darwin_amd64_v1  coder-slim_darwin_amd64_v1   coder-windows_windows_arm64
coder-darwin_darwin_arm64     coder-slim_linux_amd64_v1    config.yaml
coder-linux_linux_amd64_v1    coder-slim_windows_amd64_v1  metadata.json

@codecov
Copy link

codecov bot commented Apr 22, 2022 •
edited
Loading

Codecov Report

Merging #1105 (29b87f4) into main (2a95917) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   66.53%   66.54%           
=======================================
  Files         255      255           
  Lines       15675    15675           
  Branches      152      152           
=======================================
+ Hits        10430    10431    +1     
  Misses       4178     4178           
+ Partials     1067     1066    -1
Flag Coverage Δ
unittest-go-macos-latest 53.35% <ø> (-0.06%) ⬇️
unittest-go-postgres- 65.77% <ø> (-0.12%) ⬇️
unittest-go-ubuntu-latest 55.98% <ø> (+0.14%) ⬆️
unittest-go-windows-2022 52.74% <ø> (-0.10%) ⬇️
unittest-js 66.83% <ø> (ø)
Impacted Files Coverage Δ
codersdk/provisionerdaemons.go 59.70% <0.00%> (-5.98%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
coderd/provisionerdaemons.go 59.86% <0.00%> (-0.52%) ⬇️
provisioner/terraform/provision.go 71.39% <0.00%> (+0.43%) ⬆️
provisionerd/provisionerd.go 80.14% <0.00%> (+0.44%) ⬆️
peer/conn.go 80.20% <0.00%> (+1.26%) ⬆️
peerbroker/dial.go 83.60% <0.00%> (+6.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a95917...29b87f4. Read the comment docs.

@coadler coadler merged commit d6c1c49 into main Apr 22, 2022
@coadler coadler deleted the colin/fix-build branch April 22, 2022 20:41
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @kylecarbs @misskniss