Skip to content

feat: show dormant workspaces by default #11053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 8, 2023
Merged

feat: show dormant workspaces by default #11053

merged 8 commits into from
Dec 8, 2023

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Dec 6, 2023

Some behavior updates:

  • Dormant workspaces are now returned as part of a regular list workspaces query
  • Query param has been updated is-dormant:true -> dormant:true
  • We now display a status badge for workspaces marked dormant

Dormant workspaces with auto-deletion enabled:

image

Dormant workspace with auto-deletion disabled:

image

@sreya sreya marked this pull request as ready for review December 7, 2023 00:29
@sreya sreya requested a review from aslilac December 7, 2023 00:29
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the IsDormant name starts to make a lot more sense if we're changing the type to a boolean, but it looks good!

@sreya sreya merged commit e73a202 into main Dec 8, 2023
@sreya sreya deleted the jon/dormantredesign branch December 8, 2023 00:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants