Skip to content

fix(coderd/healthcheck): do not return null regions in RegionsResponse #11088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix(coderd/healthcheck): do not return null regions in RegionsResponse #11088

merged 1 commit into from
Dec 7, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Dec 7, 2023

Wraps some sellotape around #11087

@johnstcn johnstcn added the hotfix label Dec 7, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Dec 7, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn enabled auto-merge (squash) December 7, 2023 21:03
@johnstcn johnstcn merged commit 51687c7 into main Dec 7, 2023
@johnstcn johnstcn deleted the cj/healthcheck-wsproxy-no-null-regions branch December 7, 2023 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnstcn