Skip to content

fix: insights: remove time-dependent tests #11099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: insights: remove time-dependent tests #11099

merged 1 commit into from
Dec 8, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Dec 8, 2023

Fixes: #11097
Seen: https://github.com/coder/coder/actions/runs/7136073396/job/19433957956

Endpoint user-activity checks time.Now() while parsing request parameters, so there is no chance that the test will not be time-dependent.

I'm going to remove these test cases.

@mtojek mtojek added the hotfix label Dec 8, 2023
@mtojek mtojek marked this pull request as ready for review December 8, 2023 09:45
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mtojek mtojek enabled auto-merge (squash) December 8, 2023 09:46
@mtojek mtojek merged commit 918a824 into main Dec 8, 2023
@mtojek mtojek deleted the 11097-bad-request branch December 8, 2023 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestUserActivityInsights_BadRequest
1 participant