Skip to content

feat: Add users create and list commands #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2022
Merged

feat: Add users create and list commands #1111

merged 2 commits into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

This allows for extremely basic user management.

This allows for *extremely basic* user management.
@kylecarbs kylecarbs requested a review from coadler April 23, 2022 19:45
@kylecarbs kylecarbs self-assigned this Apr 23, 2022
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #1111 (3634330) into main (7496c3d) will decrease coverage by 0.22%.
The diff coverage is 70.87%.

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   66.61%   66.38%   -0.23%     
==========================================
  Files         257      259       +2     
  Lines       16011    16084      +73     
  Branches      156      156              
==========================================
+ Hits        10665    10677      +12     
- Misses       4266     4310      +44     
- Partials     1080     1097      +17     
Flag Coverage Δ
unittest-go-macos-latest 53.65% <65.04%> (+0.08%) ⬆️
unittest-go-postgres- 65.75% <70.87%> (-0.20%) ⬇️
unittest-go-ubuntu-latest 56.13% <65.04%> (+0.13%) ⬆️
unittest-go-windows-2022 53.18% <65.04%> (+0.16%) ⬆️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
coderd/users.go 60.36% <ø> (-0.29%) ⬇️
codersdk/users.go 65.67% <ø> (ø)
cli/usercreate.go 68.65% <68.65%> (ø)
cli/userlist.go 68.96% <68.96%> (ø)
cli/users.go 100.00% <100.00%> (ø)
coderd/database/queries.sql.go 81.79% <100.00%> (-0.22%) ⬇️
coderd/database/db.go 55.17% <0.00%> (-13.80%) ⬇️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peer/conn.go 75.63% <0.00%> (-4.32%) ⬇️
peer/channel.go 83.23% <0.00%> (-1.74%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7496c3d...3634330. Read the comment docs.

@kylecarbs kylecarbs requested a review from a team as a code owner April 23, 2022 23:24
Comment on lines +31 to +34
tableWriter := table.NewWriter()
tableWriter.SetStyle(table.StyleLight)
tableWriter.Style().Options.SeparateColumns = false
tableWriter.AppendHeader(table.Row{"Username", "Email", "Created At"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to have a central location for table styles so everything is consistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I shall follow up

@kylecarbs kylecarbs merged commit be974cf into main Apr 25, 2022
@kylecarbs kylecarbs deleted the userscmd branch April 25, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants