Skip to content

chore: make "users"."avatar_url" NOT NULL #11112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Dec 8, 2023

We try to limit null columns to cases where null and the empty value are actually distinct, as it makes the types and usage simpler in our Go code (no sql.NullString). This column has been nullable, even though it doesn't really need to be, so we should correct that!

@aslilac aslilac marked this pull request as ready for review December 8, 2023 22:29
@aslilac aslilac requested a review from Emyrk December 8, 2023 23:28
@aslilac aslilac merged commit 6775a86 into main Dec 11, 2023
@aslilac aslilac deleted the not-null-users-avatar-url branch December 11, 2023 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants