Skip to content

fix: ensure we are talking to coder on first user check #11130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix: ensure we are talking to coder on first user check #11130

merged 3 commits into from
Dec 11, 2023

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Dec 11, 2023

Closes #11006

@Emyrk
Copy link
Member

Emyrk commented Dec 11, 2023

Can we check for the x-coder-build-version header instead of a body string?

@f0ssel
Copy link
Contributor Author

f0ssel commented Dec 11, 2023

Good call @Emyrk I have updated it

@f0ssel f0ssel requested a review from Emyrk December 11, 2023 15:26
Emyrk
Emyrk reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a small unit test probably, and mentioned something about the error that I'll leave up to you.

@f0ssel f0ssel requested a review from Emyrk December 11, 2023 15:54
@f0ssel f0ssel merged commit b7ea330 into main Dec 11, 2023
@f0ssel f0ssel deleted the f0ssel/login-2 branch December 11, 2023 19:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@f0ssel f0ssel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cli): (login) Improve invalid URL experience
2 participants
@f0ssel @Emyrk