Skip to content

fix: remove URL desyncs when trying to search users table #11144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: remove URL desyncs when trying to search users table #11144

merged 2 commits into from
Dec 12, 2023

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Dec 12, 2023 •
edited
Loading

Changes made

  • Made sure that the same URL search params object from React Router is being used all throughout the users page

@Parkreiner Parkreiner self-assigned this Dec 12, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Dec 12, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner changed the title fix: remove URL search params desync for users table fix: remove URL desyncs when trying to search users table Dec 12, 2023
@Parkreiner Parkreiner enabled auto-merge (squash) December 12, 2023 00:44
@Parkreiner Parkreiner merged commit 3ce7b2e into main Dec 12, 2023
@Parkreiner Parkreiner deleted the mes/bugs/users-search branch December 12, 2023 00:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Parkreiner