Skip to content

ci: set flux version to 2.1.2 #11164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

ci: set flux version to 2.1.2 #11164

merged 2 commits into from
Dec 12, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Dec 12, 2023 •
edited
Loading

cc @deansheather

Looks like breaking change was made in 2.1.2 -> 2.2.0

Downloading flux 2.2.0 for linux/amd64
Verifying checksum
Installing flux to /opt/hostedtoolcache/flux2/2.2.0/linux/amd64
Adding flux to path
Run flux -v
flux version 2.2.0
[...]
+ flux --namespace coder reconcile helmrelease coder
✗ failed to get API group resources: unable to retrieve the complete list of server APIs: helm.toolkit.fluxcd.io/v2beta2: the server could not find the requested resource

From https://github.com/fluxcd/flux2/releases/tag/v2.2.0:

Set apiVersion: helm.toolkit.fluxcd.io/v2beta2 in the YAML files that contain HelmRelease definitions.

@johnstcn johnstcn self-assigned this Dec 12, 2023
@johnstcn
Copy link
Member Author

Opened a linked issue to update flux in dogfood cluster.

@johnstcn johnstcn added the hotfix PRs only. Harmless small change. Only humans may set this. label Dec 12, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Dec 12, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn
use the right kind of quotes because it"s very important to have the …
2371114 
…right kind of quotes or the quote police will lock you up and throw away the key
@johnstcn johnstcn enabled auto-merge (squash) December 12, 2023 20:12
@johnstcn johnstcn merged commit 2471f3b into main Dec 12, 2023
@johnstcn johnstcn deleted the cj/pin-flux-version branch December 12, 2023 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@matifali matifali Awaiting requested review from matifali

Assignees

@johnstcn johnstcn

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri