Skip to content

fix: Check for job status on another incoming #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: Check for job status on another incoming #1117

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

If a job silently failed, it wasn't possible for another one
to execute. This fixes it by using the API status to return
active state.

@kylecarbs kylecarbs requested a review from coadler April 25, 2022 01:57
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1117 (3d8878c) into main (db7ed4d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
- Coverage   66.55%   66.53%   -0.03%     
==========================================
  Files         259      257       -2     
  Lines       16155    16138      -17     
  Branches      156      156              
==========================================
- Hits        10752    10737      -15     
+ Misses       4298     4292       -6     
- Partials     1105     1109       +4     
Flag Coverage Δ
unittest-go-macos-latest ?
unittest-go-postgres- 65.94% <100.00%> (+0.02%) ⬆️
unittest-go-ubuntu-latest 56.48% <100.00%> (+0.14%) ⬆️
unittest-go-windows-2022 53.32% <100.00%> (+0.03%) ⬆️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
coderd/workspaces.go 55.62% <100.00%> (ø)
codersdk/provisionerdaemons.go 61.97% <100.00%> (+2.27%) ⬆️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
coderd/httpapi/httpapi.go 66.25% <0.00%> (-6.25%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
provisionerd/provisionerd.go 77.16% <0.00%> (-1.49%) ⬇️
cli/cliui/cliui_darwin.go
agent/usershell/usershell_darwin.go
coderd/provisionerdaemons.go 63.29% <0.00%> (+0.50%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db7ed4d...3d8878c. Read the comment docs.

If a job silently failed, it wasn't possible for another one
to execute. This fixes it by using the API status to return
active state.
@kylecarbs kylecarbs requested a review from a team as a code owner April 25, 2022 02:16
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 02:18
@kylecarbs kylecarbs merged commit 23295f7 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the fixjob branch April 25, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants