Skip to content

feat(cli): add coder open vscode #11191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 2, 2024
Merged

feat(cli): add coder open vscode #11191

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c7dba53
feat(cli): add `coder open vscode`
mafredri Dec 13, 2023
31e21fc
in-workspace detction, explicit api token generation (for printed URIs)
mafredri Dec 15, 2023
2fd2464
handle more abs paths
mafredri Dec 15, 2023
b0c3dce
add todo
mafredri Dec 15, 2023
bc71c63
fix
mafredri Dec 15, 2023
d438c49
win
mafredri Dec 15, 2023
3a69da2
table test
mafredri Dec 15, 2023
8e8e08d
rename
mafredri Dec 15, 2023
9ee8d8f
better path handling
mafredri Dec 15, 2023
257c45f
win
mafredri Dec 15, 2023
3fec654
refactor
mafredri Dec 19, 2023
0d647bd
gen
mafredri Dec 19, 2023
1202b65
allow more abs paths on windows, transform unix
mafredri Dec 19, 2023
7c3f48b
move if to switch
mafredri Dec 19, 2023
747ecad
convert / to \ for abs path check using filepath
mafredri Dec 19, 2023
caf84c5
unixToWindowsPath
mafredri Dec 19, 2023
081a006
remove filepath fallbacks on windows, go abs check is stricter
mafredri Dec 19, 2023
d09546c
yolo, you aint got nothing on me, misspell
mafredri Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove filepath fallbacks on windows, go abs check is stricter
  • Loading branch information
@mafredri
mafredri committed Jan 2, 2024
commit 081a0064c55e092ec43fc74814767777fc8c7e91
11 changes: 3 additions & 8 deletions cli/open.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,13 +236,9 @@ func waitForAgentCond(ctx context.Context, client *codersdk.Client, workspace co
return workspace, workspaceAgent, xerrors.New("watch workspace: unexpected closed channel")
}

// isWindowsAbsPath checks if the path is an absolute path on Windows. On Unix
// systems the check is very simplistic and does not cover edge cases.
// isWindowsAbsPath does a simplistic check for if the path is an absolute path
// on Windows. Drive letter or preceding `\` is interpreted as absolute.
func isWindowsAbsPath(p string) bool {
if runtime.GOOS == "windows" {
return filepath.IsAbs(p)
}

// Remove the drive letter, if present.
if len(p) >= 2 && p[1] == ':' {
p = p[2:]
Expand All @@ -259,8 +255,7 @@ func isWindowsAbsPath(p string) bool {
}

// windowsJoinPath joins the elements into a path, using Windows path separator
// and converting forward slashes to backslashes. On Unix systems a very
// simplistic join operator is used.
// and converting forward slashes to backslashes.
func windowsJoinPath(elem ...string) string {
if runtime.GOOS == "windows" {
return filepath.Join(elem...)
Expand Down