Skip to content

chore: enforcement of dbauthz tests was broken #11218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 15, 2023
Merged

chore: enforcement of dbauthz tests was broken #11218

merged 18 commits into from
Dec 15, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Dec 14, 2023

Ooooof. We forgot some...

    setup_test.go:92: Method never called: "AcquireLock"
    setup_test.go:92: Method never called: "ActivityBumpWorkspace"
    setup_test.go:92: Method never called: "AllUserIDs"
    setup_test.go:92: Method never called: "CleanTailnetCoordinators"
    setup_test.go:92: Method never called: "CleanTailnetLostPeers"
    setup_test.go:92: Method never called: "CleanTailnetTunnels"
    setup_test.go:92: Method never called: "DeleteAllTailnetClientSubscriptions"
    setup_test.go:92: Method never called: "DeleteAllTailnetTunnels"
    setup_test.go:92: Method never called: "DeleteApplicationConnectAPIKeysByUserID"
    setup_test.go:92: Method never called: "DeleteCoordinator"
    setup_test.go:92: Method never called: "DeleteExternalAuthLink"
    setup_test.go:92: Method never called: "DeleteOldProvisionerDaemons"
    setup_test.go:92: Method never called: "DeleteOldWorkspaceAgentLogs"
    setup_test.go:92: Method never called: "DeleteTailnetAgent"
    setup_test.go:92: Method never called: "DeleteTailnetClient"
    setup_test.go:92: Method never called: "DeleteTailnetClientSubscription"
    setup_test.go:92: Method never called: "DeleteTailnetPeer"
    setup_test.go:92: Method never called: "DeleteTailnetTunnel"
    setup_test.go:92: Method never called: "GetActiveWorkspaceBuildsByTemplateID"
    setup_test.go:92: Method never called: "GetAllTailnetAgents"
    setup_test.go:92: Method never called: "GetAllTailnetCoordinators"
    setup_test.go:92: Method never called: "GetAllTailnetPeers"
    setup_test.go:92: Method never called: "GetAllTailnetTunnels"
    setup_test.go:92: Method never called: "GetAppSecurityKey"
    setup_test.go:92: Method never called: "GetApplicationName"
    setup_test.go:92: Method never called: "GetAuthorizedUsers"
    setup_test.go:92: Method never called: "GetDBCryptKeys"
    setup_test.go:92: Method never called: "GetDeploymentDAUs"
    setup_test.go:92: Method never called: "GetDeploymentWorkspaceAgentStats"
    setup_test.go:92: Method never called: "GetDeploymentWorkspaceStats"
    setup_test.go:92: Method never called: "GetExternalAuthLinksByUserID"
    setup_test.go:92: Method never called: "GetFileTemplates"
    setup_test.go:92: Method never called: "GetHealthSettings"
    setup_test.go:92: Method never called: "GetHungProvisionerJobs"
    setup_test.go:92: Method never called: "GetOAuthSigningKey"
    setup_test.go:92: Method never called: "GetParameterSchemasByJobID"
    setup_test.go:92: Method never called: "GetProvisionerJobsByIDsWithQueuePosition"
    setup_test.go:92: Method never called: "GetReplicaByID"
    setup_test.go:92: Method never called: "GetTailnetAgents"
    setup_test.go:92: Method never called: "GetTailnetClientsForAgent"
    setup_test.go:92: Method never called: "GetTailnetPeers"
    setup_test.go:92: Method never called: "GetTailnetTunnelPeerBindings"
    setup_test.go:92: Method never called: "GetTailnetTunnelPeerIDs"
    setup_test.go:92: Method never called: "GetTemplateAppInsights"
    setup_test.go:92: Method never called: "GetTemplateAppInsightsByTemplate"
    setup_test.go:92: Method never called: "GetTemplateAverageBuildTime"
    setup_test.go:92: Method never called: "GetTemplateDAUs"
    setup_test.go:92: Method never called: "GetTemplateInsights"
    setup_test.go:92: Method never called: "GetTemplateInsightsByInterval"
    setup_test.go:92: Method never called: "GetTemplateInsightsByTemplate"
    setup_test.go:92: Method never called: "GetTemplateParameterInsights"
    setup_test.go:92: Method never called: "GetUserActivityInsights"
    setup_test.go:92: Method never called: "GetUserLatencyInsights"
    setup_test.go:92: Method never called: "GetUserLinksByUserID"
    setup_test.go:92: Method never called: "GetWorkspaceAgentAndOwnerByAuthToken"
    setup_test.go:92: Method never called: "GetWorkspaceAgentLifecycleStateByID"
    setup_test.go:92: Method never called: "GetWorkspaceAgentLogSourcesByAgentIDs"
    setup_test.go:92: Method never called: "GetWorkspaceAgentMetadata"
    setup_test.go:92: Method never called: "GetWorkspaceAgentScriptsByAgentIDs"
    setup_test.go:92: Method never called: "GetWorkspaceAgentStats"
    setup_test.go:92: Method never called: "GetWorkspaceAgentStatsAndLabels"
    setup_test.go:92: Method never called: "GetWorkspaceAgentsInLatestBuildByWorkspaceID"
    setup_test.go:92: Method never called: "GetWorkspaceProxyByHostname"
    setup_test.go:92: Method never called: "GetWorkspaceProxyByName"
    setup_test.go:92: Method never called: "GetWorkspaceUniqueOwnerCountByTemplateIDs"
    setup_test.go:92: Method never called: "GetWorkspacesEligibleForTransition"
    setup_test.go:92: Method never called: "InsertDBCryptKey"
    setup_test.go:92: Method never called: "InsertMissingGroups"
    setup_test.go:92: Method never called: "InsertTemplateVersionVariable"
    setup_test.go:92: Method never called: "InsertWorkspaceAgentLogSources"
    setup_test.go:92: Method never called: "InsertWorkspaceAgentLogs"
    setup_test.go:92: Method never called: "InsertWorkspaceAgentMetadata"
    setup_test.go:92: Method never called: "InsertWorkspaceAgentScripts"
    setup_test.go:92: Method never called: "InsertWorkspaceAgentStats"
    setup_test.go:92: Method never called: "InsertWorkspaceAppStats"
    setup_test.go:92: Method never called: "RevokeDBCryptKey"
    setup_test.go:92: Method never called: "TryAcquireLock"
    setup_test.go:92: Method never called: "UpdateInactiveUsersToDormant"
    setup_test.go:92: Method never called: "UpdateTemplateAccessControlByID"
    setup_test.go:92: Method never called: "UpdateTemplateScheduleByID"
    setup_test.go:92: Method never called: "UpdateTemplateWorkspacesLastUsedAt"
    setup_test.go:92: Method never called: "UpdateUserLoginType"
    setup_test.go:92: Method never called: "UpdateUserQuietHoursSchedule"
    setup_test.go:92: Method never called: "UpdateWorkspaceAgentMetadata"
    setup_test.go:92: Method never called: "UpdateWorkspaceAutomaticUpdates"
    setup_test.go:92: Method never called: "UpdateWorkspaceDormantDeletingAt"
    setup_test.go:92: Method never called: "UpdateWorkspaceProxy"
    setup_test.go:92: Method never called: "UpdateWorkspacesDormantDeletingAtByTemplateID"
    setup_test.go:92: Method never called: "UpsertAppSecurityKey"
    setup_test.go:92: Method never called: "UpsertApplicationName"
    setup_test.go:92: Method never called: "UpsertHealthSettings"
    setup_test.go:92: Method never called: "UpsertOAuthSigningKey"
    setup_test.go:92: Method never called: "UpsertTailnetAgent"
    setup_test.go:92: Method never called: "UpsertTailnetClient"
    setup_test.go:92: Method never called: "UpsertTailnetClientSubscription"
    setup_test.go:92: Method never called: "UpsertTailnetCoordinator"
    setup_test.go:92: Method never called: "UpsertTailnetPeer"
    setup_test.go:92: Method never called: "UpsertTailnetTunnel"

@Emyrk Emyrk requested a review from johnstcn December 14, 2023 21:30
johnstcn
johnstcn reviewed Dec 15, 2023
View reviewed changes
coderd/database/dbauthz/dbauthz.go
Comment on lines +65 to +67
if xerrors.Is(err, NoActorError) {
return true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@johnstcn
Copy link
Member

Green light from me once CI is happy

@Emyrk Emyrk force-pushed the stevenmasley/dbauthz_test_enforce branch from 87c19cf to b5ba222 Compare December 15, 2023 17:27
@Emyrk Emyrk enabled auto-merge (squash) December 15, 2023 18:09
@Emyrk Emyrk merged commit e63de9a into main Dec 15, 2023
@Emyrk Emyrk deleted the stevenmasley/dbauthz_test_enforce branch December 15, 2023 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @johnstcn