Skip to content

fix: Write agent URL to file for gitssh #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: Write agent URL to file for gitssh #1123

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

This was broken because gitssh couldn't find the URL.
Now it can, and SSH is confirmed to work on dogfood! 🥳

This was broken because gitssh couldn't find the URL.
Now it can, and SSH is confirmed to work on dogfood! 🥳
@kylecarbs kylecarbs requested a review from coadler April 25, 2022 03:55
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 03:57
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1123 (d721299) into main (a6ea995) will decrease coverage by 0.17%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   66.51%   66.33%   -0.18%     
==========================================
  Files         261      261              
  Lines       16194    16203       +9     
  Branches      156      156              
==========================================
- Hits        10772    10749      -23     
- Misses       4319     4342      +23     
- Partials     1103     1112       +9     
Flag Coverage Δ
unittest-go-macos-latest 53.80% <41.66%> (+0.07%) ⬆️
unittest-go-postgres- 65.66% <41.66%> (-0.27%) ⬇️
unittest-go-ubuntu-latest 56.20% <41.66%> (-0.15%) ⬇️
unittest-go-windows-2022 53.20% <41.66%> (-0.04%) ⬇️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
cli/agent.go 80.00% <25.00%> (-2.18%) ⬇️
cli/gitssh.go 52.94% <50.00%> (-1.41%) ⬇️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
coderd/httpapi/httpapi.go 66.25% <0.00%> (-6.25%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
coderd/workspaceagents.go 61.11% <0.00%> (-2.97%) ⬇️
peer/channel.go 83.23% <0.00%> (-2.32%) ⬇️
coderd/provisionerdaemons.go 62.79% <0.00%> (-0.51%) ⬇️
provisionerd/provisionerd.go 76.13% <0.00%> (-0.27%) ⬇️
peer/conn.go 80.96% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ea995...d721299. Read the comment docs.

@kylecarbs kylecarbs merged commit 8ff0c8b into main Apr 25, 2022
@kylecarbs kylecarbs deleted the agenturl branch April 25, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants