Skip to content

ci: add audit docs gen dependency on db gen #11231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2023
Merged

ci: add audit docs gen dependency on db gen #11231

merged 3 commits into from
Dec 15, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Dec 15, 2023 •
edited
Loading

Updates #11231

My current hypothesis is that #11229 is due to a race condition in make gen where one target attempts to run before queries.sql.go is generated.

EDIT: trying instead with adding dependency on queries.sql.go in audit docs generation.

@johnstcn johnstcn self-assigned this Dec 15, 2023
@johnstcn johnstcn changed the title ci: remove -j argument in make gen target ci: add audit docs gen dependency on db gen Dec 15, 2023
mafredri
mafredri approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added dependency seems like the right approach, thanks for fixing this 👍🏻

@johnstcn
Copy link
Member Author

The added dependency seems like the right approach, thanks for fixing this 👍🏻

Thank @deansheather for pointing me in the right direction!

@johnstcn johnstcn merged commit fa91992 into main Dec 15, 2023
@johnstcn johnstcn deleted the cj/ci-make-gen-no-parallel branch December 15, 2023 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@deansheather deansheather Awaiting requested review from deansheather

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri