Skip to content

feat(examples/templates): add aws vm devcontainer template #11248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 20, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Dec 17, 2023

Part of #10735

@matifali matifali self-assigned this Dec 17, 2023
@matifali matifali marked this pull request as ready for review December 17, 2023 13:50
@matifali matifali requested a review from bpmct December 19, 2023 21:54

# Start envbuilder
docker run --rm \
-v /home/${local.linux_user}/envbuilder:/workspaces \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this persists now? nice!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's persistent. I have tested.

@matifali matifali merged commit 3ffe7f5 into main Dec 20, 2023
@matifali matifali deleted the aws-devcontainer branch December 20, 2023 05:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants