chore: fix TestWorkspaceAutobuild/DormancyThresholdOK flake #11251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11238
Checking for audit logs generated from workspace builds is flaky since there exists a small gap of time between when the transaction is committed for completing a job and when we write an audit log. In fact this means any test in our
coderd
package that is asserting build-related audit logs is inherently flaky since we all use thecoderdtest.AwaitWorkspaceBuildJobCompleted
to indicate it is a good time to check for audit log generation. We should probably remove any workspace build audit log assertions fromcoderd
and test it solely inprovisionerdserver
.I opted to move this to use
dbfake
since that eliminates any raciness with the provisioner's audit logs.