Skip to content

feat: select group avatars with the emoji picker #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 3, 2024
Merged

feat: select group avatars with the emoji picker #11395

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b6fe0c
feat: select group avatars with the emoji picker
aslilac Jan 3, 2024
eb3bc93
🧹
aslilac Jan 3, 2024
f3019e9
add a suspense boundary
aslilac Jan 3, 2024
8d2c0a5
:^)
aslilac Jan 3, 2024
746eac9
🧹
aslilac Jan 3, 2024
126c47a
?:(
aslilac Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a suspense boundary
  • Loading branch information
@aslilac
aslilac committed Jan 3, 2024
commit f3019e93fa1a1131d7a30b0ce2d6001584d2a24c
4 changes: 3 additions & 1 deletion site/src/components/IconField/IconField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ export const IconField: FC<IconFieldProps> = ({
so we just have to sneak it into the DOM, which is kind of annoying, but means
that users shouldn't ever spend time waiting for it to load. */}
<div css={{ ...visuallyHidden }}>
<EmojiPicker onEmojiSelect={() => {}} />
<Suspense>
<EmojiPicker onEmojiSelect={() => {}} />
</Suspense>
</div>
</Stack>
);
Expand Down