Skip to content

test: Check if provisionerd is closed before setting run chan #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs requested a review from Emyrk April 25, 2022 15:55
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1145 (a109f2f) into main (5575e3c) will increase coverage by 8.97%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   57.54%   66.52%   +8.97%     
==========================================
  Files         261      261              
  Lines       16237    16240       +3     
  Branches      156      156              
==========================================
+ Hits         9344    10803    +1459     
+ Misses       5873     4334    -1539     
- Partials     1020     1103      +83     
Flag Coverage Δ
unittest-go-macos-latest 53.74% <0.00%> (+0.03%) ⬆️
unittest-go-postgres- 65.91% <0.00%> (?)
unittest-go-ubuntu-latest 56.41% <0.00%> (+0.06%) ⬆️
unittest-go-windows-2022 53.27% <0.00%> (+0.05%) ⬆️
unittest-js 67.28% <ø> (ø)
Impacted Files Coverage Δ
provisionerd/provisionerd.go 77.16% <0.00%> (+1.96%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
provisioner/terraform/provision.go 71.39% <0.00%> (+0.43%) ⬆️
coderd/workspaceagents.go 59.62% <0.00%> (+1.11%) ⬆️
coderd/provisionerdaemons.go 63.80% <0.00%> (+1.51%) ⬆️
coderd/templates.go 62.29% <0.00%> (+1.63%) ⬆️
peer/channel.go 84.97% <0.00%> (+1.73%) ⬆️
cli/cliui/provisionerjob.go 78.57% <0.00%> (+2.14%) ⬆️
peer/conn.go 81.72% <0.00%> (+2.79%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5575e3c...a109f2f. Read the comment docs.

@kylecarbs kylecarbs self-assigned this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants