Skip to content

feat(site): improve icon compatibility across themes #11457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 8, 2024
Merged

feat(site): improve icon compatibility across themes #11457

merged 8 commits into from
Jan 8, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jan 5, 2024

No description provided.

@aslilac aslilac force-pushed the external-icon-settings branch from 7df9a1f to 0d4ad6b Compare January 5, 2024 20:30
@aslilac aslilac requested a review from BrunoQuaresma January 5, 2024 23:24
BrunoQuaresma
BrunoQuaresma approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good on code. I'm good if Storybook is good! 👍

@aslilac aslilac merged commit 9f5a59d into main Jan 8, 2024
@aslilac aslilac deleted the external-icon-settings branch January 8, 2024 21:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @BrunoQuaresma